-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] job saved objects initialization #82450
[ML] job saved objects initialization #82450
Conversation
Pinging @elastic/ml-ui (:ml) |
// const { body } = await client.asInternalUser.count({ | ||
// index: '.ml-config', | ||
// }); | ||
// return body.count > 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@droberts195 @legrego
This function needs to check that there is at least one ML job in existence.
I believe the fastest way to do this would be to perform a count on .ml-config
. However, the kibana system user does not have read access to that index.
Instead i'm having to call both AD and DFA get endpoints to perform the same check (below).
Do you think it would be safe to give the kibana system user the ability to make this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not terribly familiar with the contents of .ml-config
. It appears to be a listing of jobs? Is there anything else in that index?
A more direct question might be: Is there any information in that index that's not accessible via the ML APIs granted to users with the manage_ml
cluster privilege? I'd be ok granting read
access to the .ml-config
index if this is true, since kibana_system
already has that cluster privilege.
On the other hand, if there is information in this index that the kibana_system
user currently doesn't have access to via other APIs, then I'd need a better understanding of that data before answering one way or another.
@elasticmachine merge upstream |
* [Enterprise Search] Migrate shared LicenseBadge component * Move files to Workplace Search dir I mistakenly thought these were shared at the Enterprise Search level
…astic/kibana into job-saved-object-initialization
* [DOCS] Updates index patterns docs * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update docs/management/index-patterns.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * [DOCS] Incorporates review comments * [DOCS] Incorporated edits Co-authored-by: Kaarina Tungseth <[email protected]>
) * Add new TelemetryLogic helpers - DRYs out need to import/pass http lib - adds product-specific helpers which DRYs out an extra line * Update all previous sendTelemetry fns to use new logic actions * Update unit tests for updated components - Create reusable mocks - Update overview_logic.ts to use new Kea mock helpers (required for recent_activity.test to pass) * Cleanup: Remove old sendTelemetry fn + update tests * [PR feedback] Correctly assert the async thrown error
* Refactor Remote Clusters client integration tests for readability. - Colocate helpers with test files. - Remove default API responses from HTTP response mocking functions to make behavior clearer at call sites.
Pinging @elastic/ingest-management (Team:Ingest Management) |
Pinging @elastic/apm-ui (Team:apm) |
A slip of the finger completely broke this PR. |
💔 Build Failed
Failed CI StepsTest FailuresPlugin Functional Tests.test/plugin_functional/test_suites/data_plugin/index_patterns·ts.data plugin index patterns can get all idsStandard Out
Stack Trace
Plugin Functional Tests.test/plugin_functional/test_suites/data_plugin/index_patterns·ts.data plugin index patterns can get all idsStandard Out
Stack Trace
Metrics [docs]async chunks size
distributable file count
page load bundle size
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
This PR has been closed, please go to #82639
Adds a check during the plugin's start to see if any
ml-job
saved objects exist. If they don't, and ML jobs do exist, it will run an initialization process to create them.Also moves the
mlLog
service to a better location.